Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Composing features tutorial; Modify Make the State conform to Equatable to pass the test. #2727

Merged

Conversation

Kyome22
Copy link
Contributor

@Kyome22 Kyome22 commented Jan 26, 2024

In Composing features of Tutorial Chapter 1, AppFeatureTests will not pass unless State is not conform to Equatable. So, I made State conform to Equatable.

https://pointfreeco.github.io/swift-composable-architecture/main/tutorials/composablearchitecture/01-04-composingfeatures/

Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@mbrandonw mbrandonw merged commit 4465e4e into pointfreeco:main Jan 26, 2024
0 of 7 checks passed
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Jan 29, 2024
…ure to from: "1.7.0" (#882)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture)
| minor | `from: "1.6.0"` -> `from: "1.7.0"` |

---

### Release Notes

<details>
<summary>pointfreeco/swift-composable-architecture
(pointfreeco/swift-composable-architecture)</summary>

###
[`v1.7.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.7.0)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.6.0...1.7.0)

#### What's Changed

- Added: Observation support
([https://github.com/pointfreeco/swift-composable-architecture/pull/2593](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2593)),
which both streamlines and soft-deprecates many concepts in the
Composable Architecture. See the [1.7 migration
guide](https://pointfreeco.github.io/swift-composable-architecture/main/documentation/composablearchitecture/migratingto1.7)
for more information on how to apply these updates to your applications.
- Infrastructure: Add CI for Swift 5.7.1
([https://github.com/pointfreeco/swift-composable-architecture/pull/2701](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2701)).
- Infrastructure: Add docs for testing `StackAction`'s case path
subscript (thanks
[@&#8203;lukeredpath](https://togithub.com/lukeredpath),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2704](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2704)).
- Infrastructure: Fixed examples CI
([https://github.com/pointfreeco/swift-composable-architecture/pull/2715](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2715)).
- Infrastructure: Fixed `TestStore.assert` docs
([https://github.com/pointfreeco/swift-composable-architecture/pull/2720](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2720)).
- Infrastructure: Use `XCTExpectFailure` from `XCTestDynamicOverlay`
([https://github.com/pointfreeco/swift-composable-architecture/pull/2721](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2721)).
- Infrastructure: Documentation typo fix (thanks
[@&#8203;JonCox](https://togithub.com/JonCox),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2723](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2723)).
- Infrastructure: Fixed concurrency docs (thanks
[@&#8203;hmhv](https://togithub.com/hmhv),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2726](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2726)).
- Infrastructure: Fixed composing features tutorial (thanks
[@&#8203;bricklife](https://togithub.com/bricklife),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2698](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2698);
thanks [@&#8203;Kyome22](https://togithub.com/Kyome22),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2727](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2727)).
- Infrastructure: Fixed 1.7 migration guide (thanks
[@&#8203;Ryu0118](https://togithub.com/Ryu0118),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2731](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2731)).

#### New Contributors

- [@&#8203;JonCox](https://togithub.com/JonCox) made their first
contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/2723](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2723)
- [@&#8203;Kyome22](https://togithub.com/Kyome22) made their first
contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/2727](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2727)

**Full Changelog**:
pointfreeco/swift-composable-architecture@1.6.0...1.7.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants